Updated hardhat template to be compatible and tests running using fhevmjs 0.3.0 and fhevm 0.3.0 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immortal-tofu
requested changes
Jan 17, 2024
tasks/deployERC20.ts
Outdated
There was a problem hiding this comment.
Why deleting this file? It's here as an example
There was a problem hiding this comment.
This was causing a conflict but I think it was because of the way utility functions were imported from fhevm (importing ethers in instance would cause hardhat to break at initialization)
There was a problem hiding this comment.
I'd suggest to restore it as an example? Easy to modify if developers want to use it for their own contract.
jatZama
force-pushed
the
updated-to-fhevm-0.3.0
branch
from
3060340
to
7349c8c
Compare
immortal-tofu
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Seems good! Just be sure it's working with [email protected]
… long form needed to get NonceManager address
fixed max-warning for solidity linter
jatZama
force-pushed
the
updated-to-fhevm-0.3.0
branch
from
bce8152
to
b0d222f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.