Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #152] Feature: add image pull policy to all container #159

Merged

Conversation

mwallschlaeger
Copy link
Contributor

Description

PR makes ImagePullPolicy configurable for all, containers defined within this chart. It further add configuration for init containers and configures init containers to use a fixed version.

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #152

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

@mwallschlaeger mwallschlaeger added enhancement New feature or request 1.1.0 refectoring refectoring labels Mar 6, 2024
@mwallschlaeger mwallschlaeger added this to the release 1.1.0 milestone Mar 6, 2024
@mwallschlaeger mwallschlaeger self-assigned this Mar 6, 2024
@mwallschlaeger mwallschlaeger changed the title Issue #152 feature add image pull policy to all container [Fixes #152] Feature: add image pull policy to all container Mar 7, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question/comment concerning imagePullPolicy: best practice is to use a digest hash to specify the image (instead of 'latest' for a version number) -- at least for productive purposes. In this case I would say, the imagePullPolicy does not matter any more? Either is image with the correct hash is available, then nothing needs to be downloaded, or it's not and thus must be downloaded...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is usually correct. But e.g. in GeoNode context it happens that geosolutions provides a new version of an image but using the same image tag. Generally it is a nice to have for users of this chart to set this policy on their on. Further this PR adds fixed versions for init containers and adds possibility to change the init container images and tags.

@mwallschlaeger mwallschlaeger merged commit 29b8c50 into main Mar 8, 2024
2 checks passed
@mwallschlaeger mwallschlaeger deleted the issue_#152_Feature_Add_ImagePullPolicy_to_all_container branch March 8, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refectoring refectoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add ImagePullPolicy to all container
2 participants