fix: asciidoc build to run as user (#802) #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrop
requested review from
kanistha and
leviferreira
and removed request for
leviferreira and
kanistha
Signed-off-by: Tronje Krop <[email protected]>
|
Works on my Ubuntu, thanks. |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue that asciidoctor output (i.e. the produced index.html) is owned by root through running the docker container using root permissions (which some browsers running in a snap refuse to open).
The pull request changes this to run asciidoctor with user permissions.
In addition, it allows running with podman instead of docker if no docker is installed.