align sync and update logs #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
sdudoladov,
Jan-M,
jopadi,
idanovinda,
hughcapet and
macedigital
as code owners
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started with a small fix of the logs for syncing the config service (endpoint vs service). There was no debug message for syncing it. While looking at the operator logs in UI I found a few more log lines which were unnecessarily using the info log level instead of debug.
I went through the code and found also debug lines which could in fact be info log lines because they happen during cluster updates. In general, syncing should only be on debug level, actual changes on info level (at least the lines explaining the diff and reporting successful update - intermediate steps can still be on debug level)
After all, most changes in this PR is changing from Debugf (and Debugln) to Debug function when no formatting is needed.