Event recorder #55
Merged
Event recorder #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… targeted Kubernetes objects Signed-off-by: Nick Jüttner <[email protected]>
njuettner
force-pushed
the
eventrecorder
branch
from
9d2e2c2
to
d95a1f0
Compare
njuettner
force-pushed
the
eventrecorder
branch
from
4931d9e
to
803fe7b
Compare
added 2 commits
September 14, 2018 17:14
Signed-off-by: Nick Jüttner <[email protected]>
… targeted Kubernetes objects Signed-off-by: Nick Jüttner <[email protected]>
… targeted Kubernetes objects Signed-off-by: Nick Jüttner <[email protected]>
mikkeloscar
reviewed
Sep 17, 2018
controller/stackset.go
Outdated
| @@ -157,7 +163,7 @@ func (c *StackSetController) Run(ctx context.Context) { | |||
| continue | |||
| } | |||
|
|
|||
| c.logger.Infof("Adding entry for StackSet %s/%s", stackset.Namespace, stackset.Name) | |||
| c.recorder.Eventf(e.StackSet, apiv1.EventTypeNormal, "CreateStackSet", "StackSet '%s/%s' added", stackset.Namespace, stackset.Name) | |||
There was a problem hiding this comment.
This is more internal logging for the controller. I think it's a bit confusing to log as an event as it will happen every time the controller restarts.
mikkeloscar
reviewed
Sep 17, 2018
controller/stackset.go
Outdated
| c.recorder.Eventf(stackset, | ||
| apiv1.EventTypeWarning, | ||
| "GetStackSet", | ||
| "Failed to get StackSet Object") |
There was a problem hiding this comment.
All events in add, update and delete are internal information for the controller. I think they are too "spammy" to log as events. They could potentially cause an event every time the controller is restarted.
Signed-off-by: Nick Jüttner <[email protected]>
njuettner
force-pushed
the
eventrecorder
branch
from
d2544b9
to
0f4c417
Compare
linki
reviewed
Sep 18, 2018
| kubernetes kubernetes.Interface | ||
| stackset stackset.Interface | ||
| kubernetes.Interface | ||
| stackset stackset.Interface |
There was a problem hiding this comment.
How do you mean? We can't do:
type x struct {
kubernetes.Interface
stackset.Interface
}as the two Interface field names would overlap.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #12