Feature/replace cleanup workflow with cli app #62

morikann · 2024-03-13T03:12:04Z

提出前チェックリスト (必須)

貢献ガイドを読み、そこに記載されているプロセスに従って PR を送信しました。
この PR によって修正される Issue を少なくとも 1 つ挙げました。または簡単な修正。
関連ドキュメントを更新・追加しました。

概要

cleanup_workflow を CLI App で置き換えました。
以下リポジトリで動作確認が可能です、ご確認の程よろしくお願いします。
- https://github.com/morikann/flutter-training-fake-template
以下のリポジトリで動作確認をし、CI が通ることを確認しました。
- refactor: Rename workflows-templates to workflows morikann/template_test#13

また、問題なくアプリが起動することも確認しました。

iOS	android

Issue（オプション）

close #41

…onException

… Process.runSync

blendthink

@morikann
いったんいくつかコメントしましたので、ご確認お願いします 🙏

tools/cleanup_template/lib/src/models/exit_status.dart

tools/cleanup_template/lib/src/file_system.dart

tools/cleanup_template/lib/cleanup_template.dart

tools/cleanup_template/lib/src/services/cleanup_service.dart

Yamasaki-pan961

対応ありがとうございます。
責務分割などだいたい良いと思いました。

いくつかコメントしましたのでご確認お願いします。

tools/cleanup_template/README.md

tools/cleanup_template/lib/cleanup_template.dart

tools/cleanup_template/lib/src/models/flutter_sdk_release.dart

tools/cleanup_template/lib/src/services/flutter_sdk_service.dart

tools/cleanup_template/build.yaml

tools/cleanup_template/lib/src/file_system.dart

tools/cleanup_template/lib/src/services/cleanup_service.dart

Yamasaki-pan961 · 2024-03-18T03:00:00Z

tools/cleanup_template/lib/src/services/cleanup_service.dart

+extension _ProcessResultExt on ProcessResult {
+  void throwExceptionIfFailed() {
+    final exitStatus = ExitStatus.fromCode(exitCode);
+    if (exitStatus != ExitStatus.success) {
+      throw ProcessRunException(exitStatus, stdout.toString());
+    }
+  }
+}


Process.runSync 自体は例外を出さないということですよね？
良さそうです

tools/cleanup_template/lib/src/services/cleanup_service.dart

…rvice.call

…rSdkRelease

morikann · 2024-03-19T04:44:28Z

FB 対応後のコードで問題なく CLI が動いていることを確認しました。
https://github.com/morikann/flutter-training-sample

blendthink · 2024-03-19T05:05:19Z

@morikann
VSCode の settings.json の記載を修正しないといけなさそうですので、ご確認お願いします 🙏
https://github.com/morikann/flutter-training-sample/blob/7cd5a19ff8da132e2b612a6eecb2a25baff6f751/.vscode/settings.json#L2

morikann · 2024-03-19T08:32:22Z

@blendthink
⇩で修正致しました🙏
6216a14

実行結果は⇩となります！
https://github.com/morikann/sample_workflow5/blob/main/.vscode/settings.json

blendthink · 2024-03-19T10:01:24Z

tools/cleanup_template/lib/src/services/cleanup_service.dart

+      );
+      _fileSystem.file(analysisOptionsPath).writeAsStringSync('''
+# https://pub.dev/packages/yumemi_lints
+include: package:yumemi_lints/flutter/$flutterVersion/recommended.yaml


yumemi_lints 2.0.0 への対応について Issue を作成しておきました。
#63

blendthink · 2024-03-19T10:13:55Z

tools/cleanup_template/lib/src/services/cleanup_service.dart

+    Process.runSync(
+      'dart',
+      ['pub', 'global', 'activate', 'fvm'],
+    ).throwExceptionIfFailed();


実行ファイルを生成して、それを利用する場合は Homebrew 経由で取得する必要がありそう。
#64

blendthink · 2024-03-19T10:20:54Z

tools/cleanup_template/lib/src/services/cleanup_service.dart

+      Process.runSync(
+        'fvm',
+        ['install', flutterVersion.toString(), '-s'],
+      ).throwExceptionIfFailed();


fvm 使わなくても対応できるかもしれないと思ったので Issue 作成しました。
考慮漏れているかもしれないので、このプルリクエストでは対応しない方針で大丈夫です、、！
#65

blendthink

少しコメントしていますが、特に問題ないかなと思いますので LGTM させていただきます！
ご対応ありがとうございます 🙏

.github/templates/.vscode/settings.json

tools/cleanup_template/lib/src/services/cleanup_service.dart

Yamasaki-pan961

ご対応ありがとうございました！LGTM

morikann added 28 commits March 13, 2024 10:45

chore: Exec dart create -t console cleanup_template

3acddf6

feat: Define ExitStatus

538f6b8

chore: install riverpod related packages

68c6dbc

chore: Setting custom_lint

9be4000

chore: Add yumemi_lints and setup

86ac153

chore: Add http package

e962203

feat: Define AppClient

4633707

chore: Add pub_semver

deaf26a

chore: Add freezed related packages and setup

cd497e8

feat: Define FlutterSdkRelease

b953cad

feat: Define FlutterSdkService to fetch latest flutter version

380cbc0

feat: Define base code of cleanup_template

9dcaa08

feat: Add process to install fvm

82c6568

chore: Add file package

3f77a74

chore: Sort dependencies to fix lint

0c0af10

chore: Add build.yaml to ignore lint for generated file

8edcf51

chore: Remove unused test content

07bb7ef

chore: Summarize exceptions raised during decoding into CheckedFromJs…

6935d03

…onException

feat: Define fileSystemProvider to DI easily

1da2836

feat: Use fileSystemProvider in app

2c6f45f

feat: Define ProcessRunException to handle for exitStatus is not 0 of…

05ca505

… Process.runSync

feat: Define CleanupService to cleanup template

01e4368

feat: Use CleanupService.call in app

fb1230d

feat: Add error handling to cleanupTemplate method

920064a

test: Add FakeCleanupService

cb0ed0e

test: Add FakeFlutterSdkService

4127ad6

chore: Add test package

bd1b24a

test: Add test of cleanupTemplate

9d80aae

morikann changed the title ~~Feature/replace cleanup workflow with cli~~ Feature/replace cleanup workflow with cli app Mar 13, 2024

chore: Add gitattributes to collapse .freezed.dart and .g.dart code

ed2c06b

blendthink reviewed Mar 18, 2024

View reviewed changes

Yamasaki-pan961 reviewed Mar 18, 2024

View reviewed changes

morikann added 9 commits March 19, 2024 13:22

refactor: Use LocalFileSystem by default in fileSystemProvider

cf964e4

refactor: Move command of "dart pub global activate fvm" to CleanupSe…

7e05e8f

…rvice.call

refactor: Use FileSystem.systemTempDirector instead of creating tmpDir

4e68745

refactor: Rename tmpDir to tempDir

d07969c

chore: Update README to specify dart version and how to exec cli

51f361a

refactor: Use map instead of simplify processing

b2d5872

refactor: Delete toolsDir in cleanup_template

cdc487f

refactor: Add @VisibleForTesting to FlutterSdkService.getLatestFlutte…

766dad4

…rSdkRelease

refactor: Delete rootDirPath variable

41e0b18

morikann requested review from blendthink and Yamasaki-pan961 March 19, 2024 04:42

fix: Setting dart.fluttrSdkPath to correct path

6216a14

blendthink reviewed Mar 19, 2024

View reviewed changes

chore: Fix comment

d7690c9

blendthink reviewed Mar 19, 2024

View reviewed changes

refactor: Change process of updating dart.flutterSdkPath

02b593f

morikann force-pushed the feature/replace_cleanup_workflow_with_CLI branch from 5c12fd7 to 02b593f Compare March 19, 2024 10:51

morikann requested a review from blendthink March 19, 2024 11:13

blendthink reviewed Mar 19, 2024

View reviewed changes

.github/templates/.vscode/settings.json Outdated Show resolved Hide resolved

tools/cleanup_template/lib/src/services/cleanup_service.dart Outdated Show resolved Hide resolved

blendthink approved these changes Mar 19, 2024

View reviewed changes

refactor: Change process of updating dart.flutterSdkPath more concisely

2287671

Yamasaki-pan961 approved these changes Mar 21, 2024

View reviewed changes

morikann merged commit 2727d8e into main Mar 21, 2024

morikann deleted the feature/replace_cleanup_workflow_with_CLI branch March 21, 2024 06:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/replace cleanup workflow with cli app #62

Feature/replace cleanup workflow with cli app #62

morikann commented Mar 13, 2024 •

edited

Loading

blendthink left a comment

Yamasaki-pan961 left a comment

Yamasaki-pan961 Mar 18, 2024

morikann commented Mar 19, 2024

blendthink commented Mar 19, 2024 •

edited

Loading

morikann commented Mar 19, 2024

blendthink Mar 19, 2024 •

edited

Loading

blendthink Mar 19, 2024

blendthink Mar 19, 2024

blendthink left a comment

Yamasaki-pan961 left a comment

Feature/replace cleanup workflow with cli app #62

Feature/replace cleanup workflow with cli app #62

Conversation

morikann commented Mar 13, 2024 • edited Loading

提出前チェックリスト (必須)

概要

Issue（オプション）

blendthink left a comment

Choose a reason for hiding this comment

Yamasaki-pan961 left a comment

Choose a reason for hiding this comment

Yamasaki-pan961 Mar 18, 2024

Choose a reason for hiding this comment

morikann commented Mar 19, 2024

blendthink commented Mar 19, 2024 • edited Loading

morikann commented Mar 19, 2024

blendthink Mar 19, 2024 • edited Loading

Choose a reason for hiding this comment

blendthink Mar 19, 2024

Choose a reason for hiding this comment

blendthink Mar 19, 2024

Choose a reason for hiding this comment

blendthink left a comment

Choose a reason for hiding this comment

Yamasaki-pan961 left a comment

Choose a reason for hiding this comment

morikann commented Mar 13, 2024 •

edited

Loading

blendthink commented Mar 19, 2024 •

edited

Loading

blendthink Mar 19, 2024 •

edited

Loading