Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update labels for better test balance #255

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Update labels for better test balance #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c221c1
Extra logs for better observability
l0kix2 Apr 23, 2024
2a4063d
Remove lbl
l0kix2 Apr 24, 2024
17c59d3
Update labels for better test balance
l0kix2 Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pr_test_e2e_update.yaml → .github/workflows/pr_test_e2e_basic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Run e2e tests
name: Run basic e2e tests

on:
pull_request:

jobs:
check:
name: Run e2e tests for update scenarios
name: Run e2e tests for basic scenarios
uses: ./.github/workflows/subflow_run_e2e_tests.yaml
with:
e2e_filter: "update"
e2e_filter: "basic"
6 changes: 3 additions & 3 deletions .github/workflows/pr_test_e2e_other.yaml → .github/workflows/pr_test_e2e_extra.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Run e2e tests
name: Run extra e2e tests

on:
pull_request:

jobs:
check:
name: Run e2e tests for non-update scenarios
name: Run e2e tests for extra scenarios
uses: ./.github/workflows/subflow_run_e2e_tests.yaml
with:
e2e_filter: "!update"
e2e_filter: "!basic"
9 changes: 3 additions & 6 deletions test/e2e/ytsaurus_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,13 +253,10 @@ type testRow struct {
var _ = Describe("Basic test for Ytsaurus controller", func() {
Context("When setting up the test environment", func() {
It(
"Should run and update Ytsaurus within same major version",
Label("update"),
getSimpleUpdateScenario("test-minor-update", ytv1.CoreImageSecond),
"Should run and update Ytsaurus within same major version", Label("basic"), getSimpleUpdateScenario("test-minor-update", ytv1.CoreImageSecond),
)
It(
"Should run and update Ytsaurus to the next major version",
Label("update"),
getSimpleUpdateScenario("test-major-update", ytv1.CoreImageNextVer),
)
It(
Expand Down Expand Up @@ -356,7 +353,7 @@ var _ = Describe("Basic test for Ytsaurus controller", func() {
},
)
It(
"Should be updated according to UpdateSelector=MasterOnly,StatelessOnly", func(ctx context.Context) {
"Should be updated according to UpdateSelector=MasterOnly,StatelessOnly", Label("basic"), func(ctx context.Context) {
namespace := "testslctother"

By("Creating a Ytsaurus resource")
Expand Down Expand Up @@ -564,7 +561,7 @@ var _ = Describe("Basic test for Ytsaurus controller", func() {
runImpossibleUpdateAndRollback(ytsaurus, ytClient)
})

It("Should run with query tracker and check that access control objects set up correctly", func(ctx context.Context) {
It("Should run with query tracker and check that access control objects set up correctly", Label("basic"), func(ctx context.Context) {
By("Creating a Ytsaurus resource")

namespace := "querytrackeraco"
Expand Down
Loading