UpdateSelector: tests #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0kix2
force-pushed
the
add_master_only_release
branch
2 times, most recently
from
535e74b
to
0637d74
Compare
l0kix2
force-pushed
the
add_master_only_release_tests
branch
from
1f18196
to
f13a341
Compare
l0kix2
force-pushed
the
add_master_only_release_tests
branch
5 times, most recently
from
a8161a3
to
d6d1529
Compare
l0kix2
force-pushed
the
add_master_only_release_tests
branch
2 times, most recently
from
3279513
to
35dd6d6
Compare
l0kix2
force-pushed
the
add_master_only_release
branch
from
479e376
to
754e71f
Compare
l0kix2
force-pushed
the
add_master_only_release_tests
branch
from
35dd6d6
to
afd8fc1
Compare
l0kix2
force-pushed
the
add_master_only_release
branch
2 times, most recently
from
120e794
to
a9d88ae
Compare
l0kix2
force-pushed
the
add_master_only_release_tests
branch
from
afd8fc1
to
1ad14fd
Compare
l0kix2
force-pushed
the
add_master_only_release
branch
2 times, most recently
from
65666f2
to
7984dc0
Compare
l0kix2
force-pushed
the
add_master_only_release_tests
branch
from
7483911
to
c430733
Compare
koct9i
approved these changes
Apr 22, 2024
test/e2e/ytsaurus_controller_test.go
Outdated
| @@ -261,7 +260,156 @@ var _ = Describe("Basic test for Ytsaurus controller", func() { | |||
| "Should run and update Ytsaurus to the next major version", | |||
| getSimpleUpdateScenario("test-major-update", ytv1.CoreImageNextVer), | |||
| ) | |||
| It( | |||
| "Should be updated according to UpdateSelector=Everything", | |||
| func(ctx context.Context) { | |||
There was a problem hiding this comment.
Weird indentation. You can put It("description", func(...) {" into one line.
If linter complains about long line we can tweak it for tests.
l0kix2
force-pushed
the
add_master_only_release_tests
branch
from
c430733
to
2c096f9
Compare
l0kix2
force-pushed
the
add_master_only_release_tests
branch
from
2c096f9
to
f784277
Compare
leo-astorsky
pushed a commit
to leo-astorsky/yt-k8s-operator
that referenced
this pull request
Aug 13, 2024
* Add UpdateStrategy field * Strategy = selector + flow * Unspecified + flow comment * regenerate * Selectors impl * Unspecified * Strategy > Selector * Selector & Flow * UpdateStrategy implementation * Strategy > Selector in impl * Strategy > Selector in impl #2 * Split selector & flow * Tests * Support selector in tests * Add exec nodes test * Fix test * Split tests * Fix indentation * Fix test after rebase * Fix test after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Added the tests for each of the used selectors with checking which pods exactly was updated (and which are not).