Skip to content

Commit

Permalink
Update labels for better test balance
Browse files Browse the repository at this point in the history
  • Loading branch information
l0kix2 committed Apr 24, 2024
1 parent 2a4063d commit 17c59d3
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Run e2e tests
name: Run basic e2e tests

on:
pull_request:

jobs:
check:
name: Run e2e tests for update scenarios
name: Run e2e tests for basic scenarios
uses: ./.github/workflows/subflow_run_e2e_tests.yaml
with:
e2e_filter: "update"
e2e_filter: "basic"
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Run e2e tests
name: Run extra e2e tests

on:
pull_request:

jobs:
check:
name: Run e2e tests for non-update scenarios
name: Run e2e tests for extra scenarios
uses: ./.github/workflows/subflow_run_e2e_tests.yaml
with:
e2e_filter: "!update"
e2e_filter: "!basic"
9 changes: 3 additions & 6 deletions test/e2e/ytsaurus_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,13 +253,10 @@ type testRow struct {
var _ = Describe("Basic test for Ytsaurus controller", func() {
Context("When setting up the test environment", func() {
It(
"Should run and update Ytsaurus within same major version",
Label("update"),
getSimpleUpdateScenario("test-minor-update", ytv1.CoreImageSecond),
"Should run and update Ytsaurus within same major version", Label("basic"), getSimpleUpdateScenario("test-minor-update", ytv1.CoreImageSecond),
)
It(
"Should run and update Ytsaurus to the next major version",
Label("update"),
getSimpleUpdateScenario("test-major-update", ytv1.CoreImageNextVer),
)
It(
Expand Down Expand Up @@ -356,7 +353,7 @@ var _ = Describe("Basic test for Ytsaurus controller", func() {
},
)
It(
"Should be updated according to UpdateSelector=MasterOnly,StatelessOnly", func(ctx context.Context) {
"Should be updated according to UpdateSelector=MasterOnly,StatelessOnly", Label("basic"), func(ctx context.Context) {
namespace := "testslctother"

By("Creating a Ytsaurus resource")
Expand Down Expand Up @@ -564,7 +561,7 @@ var _ = Describe("Basic test for Ytsaurus controller", func() {
runImpossibleUpdateAndRollback(ytsaurus, ytClient)
})

It("Should run with query tracker and check that access control objects set up correctly", func(ctx context.Context) {
It("Should run with query tracker and check that access control objects set up correctly", Label("basic"), func(ctx context.Context) {
By("Creating a Ytsaurus resource")

namespace := "querytrackeraco"
Expand Down

0 comments on commit 17c59d3

Please sign in to comment.