Skip to content

Commit

Permalink
Couple fixes for clangd language server
Browse files Browse the repository at this point in the history
- yt/client: include async_stream.h in file_reader.h
  NApi::IFileReader needs NConcurrency::IAsyncZeroCopyInputStream.

- Declare yt/yt/client/api/rpc_proxy/protocol_version_variables.h using CONFIGURE_FILE
  Otherwise resulting file does not materialize after:
  ya make --build-all --force-build-depends --replace-result --add-result=.h yt/yt/client/

  Proper source file generation is required at least for making clangd happy.

---

Pull Request resolved: ytsaurus/ytsaurus#894
commit_hash:b27f7963bc113543c0ac3842f78636be4f33416f
  • Loading branch information
koct9i authored and robot-piglet committed Oct 18, 2024
1 parent 3c1bb51 commit 7a19b35
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions yt/yt/client/api/file_reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include <yt/yt/client/object_client/public.h>

#include <yt/yt/core/concurrency/public.h>
#include <yt/yt/core/concurrency/async_stream.h>

namespace NYT::NApi {

Expand Down
5 changes: 5 additions & 0 deletions yt/yt/client/ya.make
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,11 @@ SRCS(
kafka/requests.cpp
)

CONFIGURE_FILE(
api/rpc_proxy/protocol_version_variables.h.in
api/rpc_proxy/protocol_version_variables.h
)

SRCS(
${YT_SRCS}
yt/yt/client/api/rpc_proxy/protocol_version_variables.h.in
Expand Down

0 comments on commit 7a19b35

Please sign in to comment.