Avoid uninitialized fields in TTableUploadOptions

commit_hash:560a4aa2f6f6e37f23c3fefe08f7648e9379c4d8
ytsaurus · Oct 15, 2024 · 75dc6b7 · 75dc6b7
1 parent 26f654d
commit 75dc6b7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/yt/yt/client/table_client/table_upload_options.cpp b/yt/yt/client/table_client/table_upload_options.cpp
@@ -359,8 +359,6 @@ TTableUploadOptions GetFileUploadOptions(
     auto enableStripedErasure = cypressTableAttributes.Get<bool>("enable_striped_erasure", false);
     auto erasureCodec = cypressTableAttributes.Get<NErasure::ECodec>("erasure_codec", NErasure::ECodec::None);
 
-    TTableUploadOptions result;
-
     if (path.GetAppend()) {
         THROW_ERROR_EXCEPTION("Attribute \"append\" is not supported for files")
             << TErrorAttribute("path", path);
@@ -374,13 +372,11 @@ TTableUploadOptions GetFileUploadOptions(
             << TErrorAttribute("path", path);
     }
 
+    TTableUploadOptions result;
     result.CompressionCodec = compressionCodec;
     result.ErasureCodec = erasureCodec;
     result.EnableStripedErasure = enableStripedErasure;
     result.SecurityTags = path.GetSecurityTags();
-    result.LockMode = ELockMode::Exclusive;
-    result.UpdateMode = EUpdateMode::Overwrite;
-
     return result;
 }
 

diff --git a/yt/yt/client/table_client/table_upload_options.h b/yt/yt/client/table_client/table_upload_options.h
@@ -50,20 +50,20 @@ class TEpochSchema
 
 struct TTableUploadOptions
 {
-    NChunkClient::EUpdateMode UpdateMode;
-    NCypressClient::ELockMode LockMode;
+    NChunkClient::EUpdateMode UpdateMode = NChunkClient::EUpdateMode::Overwrite;
+    NCypressClient::ELockMode LockMode = NCypressClient::ELockMode::Exclusive;
     TEpochSchema TableSchema;
     TMasterTableSchemaId SchemaId;
-    ETableSchemaModification SchemaModification;
+    ETableSchemaModification SchemaModification = ETableSchemaModification::None;
     TVersionedWriteOptions VersionedWriteOptions;
-    ETableSchemaMode SchemaMode;
-    EOptimizeFor OptimizeFor;
+    ETableSchemaMode SchemaMode = ETableSchemaMode::Strong;
+    EOptimizeFor OptimizeFor = EOptimizeFor::Lookup;
     std::optional<NChunkClient::EChunkFormat> ChunkFormat;
-    NCompression::ECodec CompressionCodec;
-    NErasure::ECodec ErasureCodec;
-    bool EnableStripedErasure;
+    NCompression::ECodec CompressionCodec = NCompression::ECodec::None;
+    NErasure::ECodec ErasureCodec = NErasure::ECodec::None;
+    bool EnableStripedErasure = false;
     std::optional<std::vector<NSecurityClient::TSecurityTag>> SecurityTags;
-    bool PartiallySorted;
+    bool PartiallySorted = false;
 
     TTableSchemaPtr GetUploadSchema() const;