Web 67 dark mode #51
Closed
Web 67 dark mode #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archessmn
requested review from
probablybenallen
and removed request for
markspolakovs
markspolakovs
requested changes
Oct 9, 2023
There was a problem hiding this comment.
The contrast on a filled crew position (line ~125 in SignupSheets.tsx) is a bit low:
And I think the theme selector icons might need alt text or an aria-label:
(though does light/dark theme even make sense if you're using a screen reader? :philosoraptor:)
Other than that, really nice work, thank you so much @archessmn!
markspolakovs
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Will let @probablybenallen give final approval, but I can't see any issues - again, thank you so much!
Removed some redundant code layout changes that slipped through in the old patch so streamline it more, should be materially identical though (except br is now a div with a class)
probablybenallen
approved these changes
Oct 10, 2023
with tailwind
Removed some redundant code layout changes that slipped through in the old patch so streamline it more, should be materially identical though (except br is now a div with a class)
|
Closing in favour of #54. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calendar dark theming should now be consistent across desktop and mobile views. Added CSS nesting to tidy up dark mode CSS for calendar. Global support for the
dark:selector for tailwind classes which will be consistent with page theme.