[WEB-64] Exclude custom crew positions from dropdown, take two #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WEB-64 Exclude custom crew positions from dropdown
In ben.allen's words, "can't wait to not need to have a million stupid used-once meme positions to scroll through for regular stuff". Possibly a |
probablybenallen
approved these changes
Oct 10, 2023
markspolakovs
deleted the
web-64-exclude-custom-crew-positions-from-dropdown-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous approach had a flaw where, if a field was a custom position, it'd get filtered out and be blank. To resolve this, move back to client-side filtering, and show it in the dropdown for that field (and only that field).