Optimise clash checking by querying at the sheet level #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed a preview of this PR to https://pr-160-internal.dev.ystv.co.uk |
markspolakovs
force-pushed
the
mp/optimise-clash-check-cache
branch
from
ead6d8d
to
3eb3fe7
Compare
|
hm, still getting a request for each time I open the modal... |
|
That's because the signupID is removed and then reset every time the modal is closed/opened, I'll have a look at it and push changes. |
|
I was wrong, forgot how I did it, but this should stop it refreshing whenever it's mounted, and make sure it gets invalidated when the sheet gets updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a micro-optimisation: since by definition all crews on the same sheet have the same timings, either all of them have clashes or none of them do, so change the cache key to the sheet ID rather than the crew ID, and manually invalidate it upon signup/dropout.