add .nvmrc to specify Node version to LTS #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent npm install errors when using Node.js versions other than LTS, added an .nvmrc file that specifies the node version to LTS.
|
|
Codecov Report
@@ Coverage Diff @@
## main #586 +/- ##
=======================================
Coverage 87.47% 87.47%
=======================================
Files 81 81
Lines 7937 7937
Branches 817 817
=======================================
Hits 6943 6943
Misses 680 680
Partials 314 314 |
hackerwins
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
To prevent npm install errors when using Node.js versions other than LTS,
added an .nvmrc file that specifies the node version to LTS.
Any background context you want to provide?
I've run into an npm install error while trying to install yorkie-js-sdk for the first time.
I realized that it was due to a node version issue, as I was using the latest node version.
I have added an .nvmrc file that sets the node version to the LTS version for the project to avoid inconvenience for others facing the same node version issue.
What are the relevant tickets?
Fixes #585
Checklist