Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simultaneous cursors example and Update examples to v0.4.6 #581

Merged
merged 11 commits into from
Aug 29, 2023

Conversation

chacha912
Copy link
Contributor

@chacha912 chacha912 commented Jul 21, 2023

What this PR does / why we need it?

Update version to v0.4.6 in examples.

  • For now, we don't know the presence of an unwatched client, so I have left a TODO comment in the examples.
    It is necessary to make modifications to include the presence in unwatched events.
  • we need to export TextRangeStruct type from yorkie-js-sdk

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@chacha912 chacha912 marked this pull request as ready for review July 21, 2023 00:11
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #581 (520c934) into main (990a6d6) will increase coverage by 0.65%.
Report is 8 commits behind head on main.
The diff coverage is 83.68%.

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   87.96%   88.62%   +0.65%     
==========================================
  Files          81       80       -1     
  Lines        8882     8893      +11     
  Branches      823      817       -6     
==========================================
+ Hits         7813     7881      +68     
+ Misses        762      704      -58     
- Partials      307      308       +1     
Files Changed Coverage Δ
src/api/converter.ts 90.72% <0.00%> (+0.16%) ⬆️
src/document/crdt/rga_tree_split.ts 91.82% <ø> (+1.67%) ⬆️
src/document/crdt/text.ts 88.31% <ø> (+5.95%) ⬆️
src/document/json/text.ts 37.87% <ø> (+4.98%) ⬆️
src/document/crdt/tree.ts 84.04% <71.11%> (-1.58%) ⬇️
src/util/index_tree.ts 63.33% <100.00%> (+1.60%) ⬆️
test/integration/tree_test.ts 99.80% <100.00%> (+0.01%) ⬆️
test/unit/document/crdt/tree_test.ts 42.66% <100.00%> (+4.73%) ⬆️
test/unit/util/index_tree_test.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

* First commit for simultaneous-cursors project.

* Work on properly attaching doc.

* Finish pen animation and add in other animations.

* Finish up the pen cursor.

* Finish animations for all 4 types of cursors.

Moving onto organizing code and polishing up functionalities
(e.g. improvements in UI/UX).

* Add functionality to show animation for other clients as well.

* Allowing client names to appear next to the cursor.

* Dropping name setting form-related code for further bug fixing.

* Changing all local data usage to using data from Yorkie.

* Working on making pen cursor smoother

---------

Co-authored-by: Yourim Cha <[email protected]>
@hackerwins hackerwins changed the title Update version to v0.4.5 in examples Update version to v0.4.6 in examples Aug 18, 2023
@hackerwins
Copy link
Member

hackerwins commented Aug 18, 2023

@chacha912 We plan to release v0.4.6 and deploy it to https://yorkie.dev soon. Should we update this PR for v0.4.6?

@chacha912
Copy link
Contributor Author

Ok, then I will add the some changes for version 0.4.6 to this branch.

@hackerwins hackerwins changed the title Update version to v0.4.6 in examples Update version to v0.4.5 in examples Aug 25, 2023
@chacha912 chacha912 changed the title Update version to v0.4.5 in examples Update version to v0.4.6 in examples Aug 29, 2023
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins changed the title Update version to v0.4.6 in examples Add simultaneous cursors example and Update examples to v0.4.6 Aug 29, 2023
@hackerwins hackerwins merged commit f45593f into main Aug 29, 2023
2 checks passed
@hackerwins hackerwins deleted the v0.4.5-example branch August 29, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants