Convert slack upload file to new api #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old approach is deprecated. Modified attacing, now without any visible urls.
files_upload_v2 is available since 3.19.5
|
Task linked: AY-6742 Convert Slack uploadFile to new api |
|
It returns the wrong formating (in curly brackets) |
|
It should be |
64qam
approved these changes
Sep 16, 2024
iLLiCiTiT
approved these changes
Sep 16, 2024
iLLiCiTiT
reviewed
Sep 16, 2024
| with open(published_file, "rb") as f: | ||
| uploaded_file = self.client.files_upload_v2( | ||
| filename=os.path.basename(published_file), | ||
| file=f.read() |
There was a problem hiding this comment.
Shouldn't this be just?
Suggested change
| file=f.read() | |
| file=f |
There was a problem hiding this comment.
It sends the images right now, could try it without .read() though.
There was a problem hiding this comment.
It works even without read, I removed it and committed.
iLLiCiTiT
added
the
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Existing
files_uploadwas made obsolete and replaced byfiles_upload_v2.This PR provides that change.
New method supports better uploads and allows to attach uploaded images without any visible urls in the Slack message as it was before
Additional info
Bumped
slack-sdkto 3.19.5 and higher.Testing notes:
test_integrationchannel!!)test_integration- it should upload and show images without visible urls