generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair action from validate correct asset context to fix the write node's filepath #8
Merged
jakubjezek001
merged 12 commits into
develop
from
bugfix/AY-6037_Nuke-context-change-not-changing-write-paths
Jul 29, 2024
Merged
Repair action from validate correct asset context to fix the write node's filepath #8
jakubjezek001
merged 12 commits into
develop
from
bugfix/AY-6037_Nuke-context-change-not-changing-write-paths
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Jul 25, 2024
BigRoy
reviewed
Jul 25, 2024
BigRoy
requested changes
Jul 26, 2024
BigRoy
reviewed
Jul 26, 2024
BigRoy
reviewed
Jul 26, 2024
BigRoy
reviewed
Jul 26, 2024
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
BigRoy
reviewed
Jul 26, 2024
BigRoy
reviewed
Jul 26, 2024
BigRoy
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need some Nuke testing by someone else. Maybe @jakubjezek001?
But code changes seem ok.
Co-authored-by: Roy Nieterau <[email protected]>
jakubjezek001
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works perfect
moonyuet
deleted the
bugfix/AY-6037_Nuke-context-change-not-changing-write-paths
branch
July 30, 2024 08:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR is to fix the bug of the validator for asset context not repairing the write nodes filepath as expected.
Additional info
n/a
Testing notes: