Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair action from validate correct asset context to fix the write node's filepath #8

Merged
merged 12 commits into from
Jul 29, 2024
Merged

Repair action from validate correct asset context to fix the write node's filepath #8

merged 12 commits into from
Jul 29, 2024

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to fix the bug of the validator for asset context not repairing the write nodes filepath as expected.

Additional info

n/a

Testing notes:

  1. Launch Nuke
  2. Change your folder path and task
  3. Publish
  4. Validate Correct Asset Context errors out
  5. Click Repair
  6. Should be fixing the filepath along with the correct context data.

BigRoy
BigRoy reviewed Jul 25, 2024
View reviewed changes
client/ayon_nuke/api/lib.py Outdated Show resolved Hide resolved
@moonyuet moonyuet requested a review from BigRoy July 26, 2024 05:35
BigRoy
BigRoy requested changes Jul 26, 2024
View reviewed changes
client/ayon_nuke/plugins/publish/validate_asset_context.py Outdated Show resolved Hide resolved
client/ayon_nuke/api/plugin.py Outdated Show resolved Hide resolved
@moonyuet moonyuet requested a review from BigRoy July 26, 2024 09:24
@moonyuet moonyuet requested a review from BigRoy July 26, 2024 11:58
@moonyuet moonyuet requested a review from BigRoy July 26, 2024 12:05
@moonyuet moonyuet requested a review from BigRoy July 26, 2024 12:20
BigRoy
BigRoy approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need some Nuke testing by someone else. Maybe @jakubjezek001?

But code changes seem ok.

client/ayon_nuke/api/plugin.py Outdated Show resolved Hide resolved
@BigRoy BigRoy added the type: bug Something isn't working label Jul 26, 2024
jakubjezek001
jakubjezek001 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfect

@jakubjezek001 jakubjezek001 merged commit 9ea6c7f into develop Jul 29, 2024
1 check passed
@moonyuet moonyuet deleted the bugfix/AY-6037_Nuke-context-change-not-changing-write-paths branch July 30, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moonyuet @BigRoy @jakubjezek001