Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publishing USD from maya with asset/shot contributions enabled #32

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Fix publishing USD from maya with asset/shot contributions enabled #32

merged 4 commits into from
Jul 24, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 18, 2024 •
edited
Loading

Fix a bug where USD usdAsset (asset and shot) contributions fail to publish.

Additional Info

Clickup AY-6115

Testing notes

  1. Publish a USD file from Maya should not raise any errors WITH USD Contribution checkbox enabled
  2. Publish a USD file from Maya should not raise any errors WITH USD Contribution checkbox disabled

The USD contribution checkbox:

Thanks - on a USD instance there should be a setting on the instance under a section USD Contribution which has Enable checkbox.

See also screenshots here.

@BigRoy BigRoy added the type: bug Something isn't working label Jul 18, 2024
@BigRoy BigRoy requested a review from m-u-r-p-h-y July 18, 2024 11:08
@BigRoy BigRoy self-assigned this Jul 18, 2024
@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 18, 2024

Seems another fix was missing - copied that over now as well.
It should work now:

image

@BigRoy BigRoy requested a review from antirotor July 18, 2024 11:21
@m-u-r-p-h-y m-u-r-p-h-y assigned antirotor and unassigned BigRoy Jul 18, 2024
@BigRoy BigRoy requested a review from moonyuet July 23, 2024 20:57
@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 24, 2024

This PR will need to be merged to fix the USD integration after the ayon-maya separation. Anyone can review this @antirotor and merged so we don't leave maya in the broken state?

@moonyuet are you able to test-run this?

Client also reported this issue.

moonyuet
moonyuet approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Maya 2025 with or without Include User Defined Attributes

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 24, 2024 •
edited
Loading

Tested successfully in Maya 2025 with or without Include User Defined Attributes

Thanks - on a USD instance there should be a setting on the instance under a section USD Contribution which has Enable checkbox.

See also screenshots here.

545ce035e34eceab2a39337c587ceeb78a9162a8

@moonyuet
Copy link
Member

Tested successfully in Maya 2025 with or without Include User Defined Attributes

Thanks - on a USD instance there should be a setting on the instance under a section USD Contribution which has Enable checkbox.

See also screenshots here.

545ce035e34eceab2a39337c587ceeb78a9162a8

image
image

@BigRoy BigRoy merged commit aabee93 into ynput:develop Jul 24, 2024
1 check passed
@BigRoy BigRoy deleted the bugfix/fix_usd_publish_asset_contribution branch July 24, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonyuet moonyuet moonyuet approved these changes

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@antirotor antirotor

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BigRoy @moonyuet @antirotor