Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift: Set Rendersettings actually apply multilayer_exr and force_combine #29

Merged

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 17, 2024

Changelog Description

Fix applying of Force combine beauty and AOVs into a single file and Multipart EXR in Redshift Rendersettings from settings defined in AYON settings.

Additional info

The settings already existed but seemed to have been used nowhere - even back in OpenPype.

Note: There has been some discussion that Multilayer is not the same as Multipart so either the settings name and label is wrong, or we're setting the wrong attribute here? Any clue @m-u-r-p-h-y @antirotor ?

Testing notes:

  1. Change settings
ayon+settings://maya/render_settings/redshift_renderer/multilayer_exr
ayon+settings://maya/render_settings/redshift_renderer/force_combine
  1. Launch Maya, set redshift as renderer.
  2. Click "AYON > Set Render Settings" in menu in Maya
  3. The Redshift render settings should now have been updated.

image

@BigRoy BigRoy added the type: bug Something isn't working label Jul 17, 2024
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it only works partially for me. The attributes from Common section of Render Globals are set correctly but other attributes are untouched

image

@m-u-r-p-h-y
Copy link
Member

regarding the multilayer and multipart this is the way I understand the RS settings

image

Force combine beauty and AOVs into single file = multilayer
Multipart EXR = multipart

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 18, 2024

regarding the multilayer and multipart this is the way I understand the RS settings

image

Force combine beauty and AOVs into single file = multilayer Multipart EXR = multipart

Thanks - I'll rename the setting, because it was broken anyway it won't break a production case anyway. :)

@BigRoy BigRoy self-assigned this Jul 18, 2024
@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 19, 2024

it only works partially for me. The attributes from Common section of Render Globals are set correctly but other attributes are untouched

image

Should be fixed - it seems updated in recent Redshift versions, so I've justed matched it. Tested with Maya 2024.2 and Redshift 3.6.03.

@BigRoy BigRoy requested a review from m-u-r-p-h-y July 19, 2024 00:05
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not working for me.

not sure if running the dev mode is enough or I need to build the full addon and upload it to the server

image

GI engines are not set either

I would also match the order of attributes with the render settings

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 19, 2024

@m-u-r-p-h-y you'd need to build and redeploy the addon for updated settings, yes.

If still not working - what Maya version and Redshift version are you using?

@m-u-r-p-h-y
Copy link
Member

@m-u-r-p-h-y you'd need to build and redeploy the addon for updated settings, yes.
will do

If still not working - what Maya version and Redshift version are you using?

M2025.1
RS3.6.04

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 24, 2024

M2025.1
RS3.6.04

Just to be sure - you did try with a re-uploaded addon package @m-u-r-p-h-y ?

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recreated and reuploaded the addon.

all options are propagated correctly. (even the custom attributes)
image
image

@BigRoy BigRoy merged commit a3e4f03 into ynput:develop Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants