-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure implicit thumbnail in higher priority over the thumbnail source #26
Make sure implicit thumbnail in higher priority over the thumbnail source #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine and without any issues...
Tested in maya 2024
LGTM
when testing in All good. |
@moonyuet could you add to the PR description which of the two thumbnails now take higher priority? Which of the two will be used and which will be discarded? That was a topic for discussion here so it would be great if the PR would clearly state that (and have it confirmed/tested also via the testing notes) Also tagging @dee-ynput because there was still (as far as I know unanswered 'to be discussed' point here raised here) |
The extract thumbnail from the host takes higher priority for this PR, not the thumbnail source which takes the screengrab as thumbnail. |
Changelog Description
When users trying to create screengrab thumbnails and publish along with the review product type, it will error out the intgerate.py due to the duplicate of the thumbnail representation data. This PR is to make sure the extract thumbnail is always at the higher priority than the extract thumbnail sources
Additional info
please test on some other hosts with thumbnail extractors in review family, maybe similar bug is hit when you publish both screengrab and review family
ported from ynput/ayon-core#695
Testing notes: