Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate clashing siblings: Fix support for runtime instances #128

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 29, 2024

Changelog Description

Ignore runtime instances for the validation

Additional info

Avoids this error:

Traceback (most recent call last):
  File "C:\Users\Maqina03\AppData\Local\Ynput\AYON\dependency_packages\ayon_2407291312_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
    runner(*args)
  File "C:\Users\Maqina03\AppData\Local\Ynput\AYON\addons\maya_0.2.13-cb.1\ayon_maya\plugins\publish\validate_clashing_sibling_names.py", line 71, in process
    if not self.is_strip_namespaces_enabled(instance):
  File "C:\Users\Maqina03\AppData\Local\Ynput\AYON\addons\maya_0.2.13-cb.1\ayon_maya\plugins\publish\validate_clashing_sibling_names.py", line 137, in is_strip_namespaces_enabled
    if _is_plugin_active(plugin_name):
  File "C:\Users\Maqina03\AppData\Local\Ynput\AYON\addons\maya_0.2.13-cb.1\ayon_maya\plugins\publish\validate_clashing_sibling_names.py", line 110, in _is_plugin_active
    publish_attributes = instance.data["publish_attributes"]
KeyError: 'publish_attributes'

For example when publishing usd with contribution workflow enabled.

Testing notes:

  1. Validation should not crash on runtime instances, e.g. usd workflow contributions

@BigRoy BigRoy added the type: bug Something isn't working label Sep 29, 2024
@BigRoy BigRoy self-assigned this Sep 29, 2024
@LiborBatek
Copy link
Member

@BigRoy sry, could provide some testing steps as Im not much familiar with that runtime instance term aka how to set it up for testing purposes, thx

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
LGTM

@BigRoy
Copy link
Contributor Author

BigRoy commented Sep 30, 2024

sry, could provide some testing steps as Im not much familiar with that runtime instance term aka how to set it up for testing purposes, thx

Ah sorry,

@LiborBatek just publish a usd instance with asset contribution checkbox enabled on the instance (it's enabled by default)

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did try on both model and animation into USD and seems fine without causing any issues...publishing well
Screenshot 2024-09-30 154125

@BigRoy BigRoy merged commit 305fdb1 into ynput:develop Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants