Remove deprecated color management settings #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support older than Maya 2022 anyway because those are Py2)
BigRoy
requested review from
m-u-r-p-h-y,
antirotor,
iLLiCiTiT and
LiborBatek
BigRoy
commented
Sep 16, 2024
|
We're now using this in production on our end. 👍 |
moonyuet
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Removes deprecated color management settings for Maya.
This is a tricky one, because this will be backwards compatible for everyone who had not previously EXPLICITLY enabled
ayon+settings://maya/imageio/workfile/enabledbecause it would've been disabled before and in that case they were still using the deprecated settings. Now, the newer values will apply when enabled by default.If the setting was overridden explicitly to disabled it will now log a message that the AYON Maya workfile color management is disabled.
Additional info
This was "deprecated" since OpenPype 3.15.5.
Also removed the legacy OCIO config settings that were for Maya 2020 and older since those are Py2 anyway and are already unsupported.
Testing notes: