Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Deadline Submission #49

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from
Draft

Refactor Deadline Submission #49

wants to merge 21 commits into from

Commits on Oct 16, 2024

  1. New Settings for CollectJobInfoItem 

    These settings should be base of generic JobInfo values for Deadline submission. They should contain variables previously contained in Submit* Settings.
Some of them should be exposed to Publisher UI as artist overrides.
    @kalisp
    kalisp committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d1a883b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Matched implemented artist overrides definitions

    @kalisp
    kalisp committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f72e87f View commit details
    Browse the repository at this point in the history

  2. Added collected jobInfo object

    @kalisp
    kalisp committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2b29403 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Use DeadlineJobInfo as collector object 

    It was decided that dataclasses should be used instead of attrs. This moves DeadlineJobInfo which is full mapping of JobInfo from abstract submitters to collectors to limit need of new class and necessary remapping later.
    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cb0d24d View commit details
    Browse the repository at this point in the history

  2. Removed six dependency

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    37c0a0d View commit details
    Browse the repository at this point in the history

  3. Implemented new generic method applicable for all DCC 

    Added new argument for old get_job_info (which should be probabaly renamed) to pass base of prepared object to be enhanced with DCC specific fields
    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3358838 View commit details
    Browse the repository at this point in the history

  4. Removed unneeded imports

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    60da8b9 View commit details
    Browse the repository at this point in the history

  5. Do not pass empty string to DeadlineJobInfo 

    Empty strings overrides None defaults which might cause issue (it definitely does for job_delay).
    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ae3c739 View commit details
    Browse the repository at this point in the history

  6. Removed unneded imports

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1c8990a View commit details
    Browse the repository at this point in the history

  7. Reimplemented get_job_info, moved to generic impl

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    57860ce View commit details
    Browse the repository at this point in the history

  8. Removed storign deadline info to instance 

    'deadline' dictionary wasnt used at all, it contained large DeadlineJobInfo which just enlarged metadata json unnecessary.
    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    10f566f View commit details
    Browse the repository at this point in the history

  9. Updates to DeadlineJobInfo to match previous implementation 

    It is handling EnvironmentKey* type of fields
    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bbb12b7 View commit details
    Browse the repository at this point in the history

  10. Added Frames field for explicit rendering

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c26c997 View commit details
    Browse the repository at this point in the history

  11. Run CollectJobInfo only locally

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e1eba7f View commit details
    Browse the repository at this point in the history

  12. Implemented explicit frames filtering on simple files 

    Not yet working on AOVs.
    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8062462 View commit details
    Browse the repository at this point in the history

  13. Reworked removal of deadline in submit job 

    Deadline portion must be there for ValidateExpectedFiles
    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ec908e0 View commit details
    Browse the repository at this point in the history

  14. Removed empty line

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    64b22ff View commit details
    Browse the repository at this point in the history

  15. Added empty line at the end

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0d3125d View commit details
    Browse the repository at this point in the history

  16. Formatting

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c206b24 View commit details
    Browse the repository at this point in the history

  17. Removed forgotten dev code

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    803c25c View commit details
    Browse the repository at this point in the history

  18. Refactor batchname

    @kalisp
    kalisp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    201c5b8 View commit details
    Browse the repository at this point in the history