Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Attribute values: Implemented iter #968

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Added implementation to iterate over AttributeValues.

Additional info

AttributeValues should behave as dict but iterating over it does not behave the same way.

Testing notes:

  1. If is possible to iterate over AttributeValues object to get keys.

Resolves #804

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 24, 2024
@iLLiCiTiT iLLiCiTiT requested a review from BigRoy October 24, 2024 12:53
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Oct 24, 2024
@ynbot ynbot added the size/XS label Oct 24, 2024
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@iLLiCiTiT iLLiCiTiT merged commit f11fba0 into develop Oct 24, 2024
9 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/804-make-publishattributevalues-behave-like-dict-when-iterating branch October 24, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make PublishAttributeValues behave like dict when iterating
3 participants