Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnails: add Unreal to hosts #952

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Thumbnails: add Unreal to hosts #952

merged 1 commit into from
Oct 14, 2024

Conversation

antirotor
Copy link
Member

Changelog Description

Unreal can do local rendering/publishing too, enabling thumbnails for renders

Testing notes:

  1. Publish local render from unreal
  2. Observe nice and shiny thumbnail

@antirotor
🎨 add unreal to hosts
36541c5 
unreal can do local rendering/publishing and without it, it is missing thumbnail.
@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Oct 11, 2024
@antirotor antirotor self-assigned this Oct 11, 2024
@ynbot ynbot added the size/XS label Oct 11, 2024
moonyuet
moonyuet approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thumbnail shows as expected.
image

LiborBatek
LiborBatek approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely...

image

@moonyuet moonyuet merged commit 360a7d2 into develop Oct 14, 2024
11 checks passed
@moonyuet moonyuet deleted the enhancement/add-unreal-to-extract-thumbnails branch October 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonyuet moonyuet moonyuet approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees

@antirotor antirotor

Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antirotor @moonyuet @LiborBatek @ynbot