Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher: Remove pyblish exception log from records #938

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Remove exception from log records.

Additional info

Pyblish process method is logging exception which is added to records of our custom message handler.

Testing notes:

  1. Validation error does not add error log to logs with traceback.

Resolves #937

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Oct 3, 2024
@iLLiCiTiT iLLiCiTiT self-assigned this Oct 3, 2024
@ynbot ynbot added the size/XS label Oct 3, 2024
@iLLiCiTiT iLLiCiTiT requested a review from BigRoy October 3, 2024 15:41
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix the issue:

image

image

But I'd consider it a hotfix really. We would really want to preferably 'catch' this differently if we can because it feels relatively hacky to just pick the last log entry and discard it like this. So maybe a # TODO alongside this in the code would be nice so we can keep it in mind for if we can think of better solutions.

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Oct 3, 2024

But I'd consider it a hotfix really. We would really want to preferably 'catch' this differently if we can because it feels relatively hacky to just pick the last log entry and discard it like this.

Only proper solution to fix this is to not use pyblish.

@iLLiCiTiT iLLiCiTiT closed this Oct 3, 2024
@iLLiCiTiT iLLiCiTiT reopened this Oct 3, 2024
@iLLiCiTiT iLLiCiTiT merged commit 64a6322 into develop Oct 3, 2024
10 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/937-publish-validation-errors-show-traceback-in-artist-facing-reports branch October 3, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish Validation Errors show traceback in artist facing reports
3 participants