This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Gaffer tweaks for ayon-gaffer #6254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Althoug this adds 'explicit_cleanup_paths' which I added at the time since I couldn't get the actual explicit_cleanup paths work. This also messes with submit_publish_job.py's way of fetching AVALON_ASSET and AVALON_TASK, trying first to get the data from the instance instead of just looking at the context
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| ] | ||
|
|
||
| for key in extra_instance_data: | ||
| if key in instance.data.keys(): |
| "AVALON_ASSET": instance.context.data["asset"], | ||
| "AVALON_TASK": instance.context.data["task"], | ||
| "AVALON_ASSET": instance.data['asset'] or instance.context.data["asset"], | ||
| "AVALON_TASK": instance.data['task'] or instance.context.data["task"], |
| @@ -189,8 +189,8 @@ def _submit_deadline_post_job(self, instance, job, instances): | |||
| environment = { | |||
| "AVALON_DB": os.environ["AVALON_DB"], | |||
| "AVALON_PROJECT": instance.context.data["projectName"], | |||
| "AVALON_ASSET": instance.context.data["asset"], | |||
| "AVALON_TASK": instance.context.data["task"], | |||
| "AVALON_ASSET": instance.data['asset'] or instance.context.data["asset"], | |||
ynbot
added
size/XS
|
@sjt-rvx we're archiving OP repo, so i'm closing this. any further work should be done in AYON repos. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I have moved all the gaffer stuff into an addon we still need to alter some things in the openpype core (ayon-core in the near future). However this adds also a bit of other things I was hoping to get rid of before this becomes proper. This adds 'explicit_cleanup_paths' to instances which
cleanup.pySo we can run arbitrary cleanup on the farm. I added this at the time since I couldn't get the actual explicit_cleanup paths work. This also messes with submit_publish_job.py's way of fetching AVALON_ASSET and AVALON_TASK, trying first to get the data from the instance instead of just looking at the context. This is kind of a must for multi-context publishes (publishing into several folders in one go).The gaffer addon in its roughest form:
https://github.com/RVXStudio/ayon-gaffer
Testing notes: