Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Arnold Scene Source Raw - OP-8014 #6182

Merged
merged 9 commits into from
May 3, 2024

Conversation

tokejepsen
Copy link
Member

@tokejepsen tokejepsen commented Jan 30, 2024

Changelog Description

This PR is to try and re-instate some flexibility to the Arnold Scene Source family, which got restricted by #4449

The proxy workflow introduced was actually broken due to #4460.

We can now have any nodes directly in the instance set, which should be backwards compatible of the Arnold Scene Source before the overhaul in #4449.
The content and proxy sets works as well, but not at the same time as the raw nodes directly in the instance set. There is a validator in place to prevent using a single instance for both workflows.

Now the question is whether we should have this as a single family or split somehow?
The workflow of having nodes directly in the instance set, compared to content and proxy set, can be documented, so I see this as most a matter of terminology.
Arnold Scene Source makes sense to have as a family, but only if its a the raw output with little to no validation, similar to Maya Scene. But then I'm not sure what to call the other family that has more of a workflow in place, which is similar to Model and Pointcache.

Testing notes:

  1. Follow Arnold guide for publishing; https://ayon.ynput.io/docs/addon_maya_arnold_artist. Ignoring the content_SET does not exists.

- against raw and content nodes together.
- hidden nodes for extraction.
@ynbot ynbot added type: feature Larger, user affecting changes and completely new things host: Maya size/S Denotes a PR changes 100-499 lines, ignoring general files labels Jan 30, 2024
@mkolar
Copy link
Member

mkolar commented Feb 9, 2024

@antirotor doesn't this solve the issue with ASS we talked about int he office?

@antirotor
Copy link
Member

I am little struggling with it but - if Arnold Scene Source is to be "raw" form, we can have ASS Standin for the more restrictive one - loaders to support both of them. Truth to be told, I really don't know the right name for it. Maybe even something like Arnold Scene Source - Raw and Arnold Scene Source?

@tokejepsen
Copy link
Member Author

How about Arnold Scene Source and Arnold Scene Source Proxy?

The workflow that is in place, is for proxy loading in the viewport. I think we should also get rid of the content objectset since we'll have two families anyways to differentiate workflows, so "content" nodes will just be in the root objectset for the Arnold Scene Source Proxy.

@antirotor
Copy link
Member

How about Arnold Scene Source and Arnold Scene Source Proxy?

The workflow that is in place, is for proxy loading in the viewport. I think we should also get rid of the content objectset since we'll have two families anyways to differentiate workflows, so "content" nodes will just be in the root objectset for the Arnold Scene Source Proxy.

Yep, but we need to handle backwards compatibility with existing scenes

@tokejepsen
Copy link
Member Author

Yep, but we need to handle backwards compatibility with existing scenes

@antirotor I think since the proxy workflow was broken due to #4460, there would only be roughly 2 months where people could have made valid proxy ass publishing. Then its been 1 year with the broken proxy workflow, which probably shows how much its used and that we dont need to worry about backward compatibility for Arnold Scene Source Proxy
For Arnold Scene Source we would be restoring backward compatibility with this PR, so I dont think we need to worry about any backward compatibility.

@tokejepsen tokejepsen marked this pull request as ready for review April 8, 2024 17:02
@tokejepsen tokejepsen removed their assignment Apr 8, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im constantly getting validation errors when putting geometries into ass instance...

Im using the first type without Proxy suffix

My geometries have some dependencies as they are skinned and with anim rig...but I can produce pointcache for such selection easily for comparison...

So my question is, should be this instance type so limited?? as I dont see any point constrain it so much for the user... why I should care about something outside of actual publish instance aka ass ??

image

@LiborBatek
Copy link
Member

here for example successful Publish for pointcache with the same selection of objects...

image

@tokejepsen
Copy link
Member Author

@LiborBatek could you show the instance or send me the workfile?

@LiborBatek
Copy link
Member

LiborBatek commented Apr 19, 2024

Here is my Arnold scene source instance details...

Screenshot 2024-04-19 094405

@tokejepsen
Copy link
Member Author

So my question is, should be this instance type so limited?? as I dont see any point constrain it so much for the user... why I should care about something outside of actual publish instance aka ass ??

@LiborBatek from the screen grab it looks like some geometries are being flagged as hidden but they might not be?

To debug this, could you maybe send me the rig you are using?

@tokejepsen
Copy link
Member Author

@LiborBatek I've found the bug that caused the validator to falsely flag nodes as hidden. Give it another test when you have time.

@tokejepsen tokejepsen requested a review from BigRoy April 30, 2024 10:28
@tokejepsen tokejepsen requested a review from BigRoy April 30, 2024 10:54
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did another testing round and all working fine and without any issues...

@mkolar mkolar merged commit ca8dc5c into develop May 3, 2024
13 checks passed
@ynbot ynbot added this to the next-patch milestone May 3, 2024
@tokejepsen tokejepsen deleted the feature/OP-8014_arnold-scene-source-raw branch May 3, 2024 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya port to AYON size/S Denotes a PR changes 100-499 lines, ignoring general files type: feature Larger, user affecting changes and completely new things
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants