deadline shortcut added to settings with type error #5274
Conversation
MustafaJafar
added
community contribution
module: Deadline
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| os.environ[key] = value | ||
|
|
||
| # Call the method to open the app | ||
| process = subprocess.Popen(["xterm", "-e", deadline_paths["linux"][0]]) |
There was a problem hiding this comment.
local variable 'process' is assigned to but never used
| get_system_settings, | ||
| get_general_environments | ||
| ) | ||
| class LaunchDeadline(LauncherAction): |
|
I don't understand what this should be doing. Just adding Deadline Monitor icon (btw path to the icon is hardcoded)? |
|
This PR seems to try and expose a "launch deadline" from the OpenPype launcher? The PR seems wrong in many ways - hardcoded paths, linux only, doesn't use application launching logic even though it tries to emulate the behavior somewhat with exposing I agree with @kalisp this PR is a bit unclear entirely why it's a needed feature - what does it offer and why do you need it like that? If it makes sense I suppose we can discuss cleaning up the code. |
|
Closing for now. Please provide a clear use case for this and reopen. |
Changelog Description
We added to json files new keys to deadline so it has a proper interface with its relatives paths on different OS.
Additional info
While opening the settings you will have a Attribute error, if u have any clue to solve it I'd like your help
Testing notes: