Merge pull request #6186 from Sponge96/max_tweaks

Max: updated implementation of save_scene + small QOL improvements to host

openpype/hosts/max/api/pipeline.py

@@ -62,9 +62,8 @@ def context_setting():
         rt.callbacks.addScript(rt.Name('postWorkspaceChange'),
                                self._deferred_menu_creation)
 
-    def has_unsaved_changes(self):
-        # TODO: how to get it from 3dsmax?
-        return True
+    def workfile_has_unsaved_changes(self):
+        return rt.getSaveRequired()
 
     def get_workfile_extensions(self):
         return [".max"]

openpype/hosts/max/plugins/publish/save_scene.py

@@ -1,21 +1,23 @@
 import pyblish.api
-import os
+from openpype.pipeline import registered_host
 
 
 class SaveCurrentScene(pyblish.api.ContextPlugin):
-    """Save current scene
-
-    """
+    """Save current scene"""
 
     label = "Save current file"
     order = pyblish.api.ExtractorOrder - 0.49
     hosts = ["max"]
     families = ["maxrender", "workfile"]
 
     def process(self, context):
-        from pymxs import runtime as rt
-        folder = rt.maxFilePath
-        file = rt.maxFileName
-        current = os.path.join(folder, file)
-        assert context.data["currentFile"] == current
-        rt.saveMaxFile(current)
+        host = registered_host()
+        current_file = host.get_current_workfile()
+
+        assert context.data["currentFile"] == current_file
+
+        if host.workfile_has_unsaved_changes():
+            self.log.info(f"Saving current file: {current_file}")
+            host.save_workfile(current_file)
+        else:
+            self.log.debug("No unsaved changes, skipping file save..")

openpype/hosts/max/startup/startup.ms

@@ -7,6 +7,9 @@
 
     local pythonpath = systemTools.getEnvVariable "MAX_PYTHONPATH"
     systemTools.setEnvVariable "PYTHONPATH" pythonpath
+
+    /*opens the create menu on startup to ensure users are presented with a useful default view.*/
+    max create mode
 
     python.ExecuteFile startup
-)
+)