support marks on element nodes #157
Open
+73
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dmonad, as I understand it you wanted to add some tests for this. I had a hand in making this change and am willing to add tests if you find it necessary. |
|
Anything pending to get this merged? |
|
Please get this merged 🙏🏼 🙏🏼 😭 😮💨 |
|
Can somebody share any update we really need this issue fixed asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1: #47
Issue TipTap: ueberdosis/tiptap#4339
PR 1: #63
PR 2: #135
But updated so that it works to parse yDoc to JSON aswell.
I made sure that the tests run and formatting run green, if anything else is a concern feel free to let me know I will change as soon as possible