Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Connection.php #370

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Update Connection.php #370

merged 1 commit into from
Nov 13, 2023

Conversation

spzgy
Copy link
Contributor

@spzgy spzgy commented Nov 13, 2023

The startSession method has only one parameter pass

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues

The startSession method has only one parameter pass
Copy link

what-the-diff bot commented Nov 13, 2023

PR Summary

  • Modification in Connection.php file
    • The startTransaction function has been updated. Previously it had an argument $isNew, which is no longer required. This simplifies the calling process of this function, making the code cleaner and easier to understand.
    • The output of the startSession function, which we use in the startTransaction, is now stored in a new variable named $session. This change should help in monitoring the session's starting process more effectively.

@bizley bizley merged commit 3648ec5 into yiisoft:master Nov 13, 2023
14 of 15 checks passed
@bizley
Copy link
Member

bizley commented Nov 13, 2023

👍🏻

@spzgy spzgy deleted the patch-1 branch November 22, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants