Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test case improving #316

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

ziaratban
Copy link
Contributor

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? no

default db is mongodb component in across all application.(base on yii rule)
so no need call getConnection() method in everywhere except in special cases.

i changed some files. please help me for fixing this dirty codes.

default db is `mongodb` component in across all application.
so no need `getConnection` method in everywhere except in special cases
tests/ActiveDataProviderTest.php Outdated Show resolved Hide resolved
@samdark samdark closed this Jul 17, 2020
@samdark samdark reopened this Jul 19, 2020
@ziaratban ziaratban closed this Oct 11, 2020
@ziaratban ziaratban deleted the test-case-db-problem branch October 11, 2020 09:34
@ziaratban ziaratban restored the test-case-db-problem branch October 11, 2020 09:52
@ziaratban ziaratban reopened this Oct 11, 2020
@ziaratban ziaratban force-pushed the test-case-db-problem branch 3 times, most recently from fd52494 to 6c0ef36 Compare October 11, 2020 13:26
This was referenced Oct 11, 2020
@samdark samdark added this to the 2.1.10 milestone Oct 13, 2020
@samdark samdark added the status:code review The pull request needs review. label Oct 30, 2020
tests/ActiveDataProviderTest.php Outdated Show resolved Hide resolved
tests/ActiveFixtureTest.php Outdated Show resolved Hide resolved
tests/ActiveFixtureTest.php Outdated Show resolved Hide resolved
tests/ActiveFixtureTest.php Outdated Show resolved Hide resolved
tests/ActiveFixtureTest.php Outdated Show resolved Hide resolved
tests/ActiveFixtureTest.php Outdated Show resolved Hide resolved
tests/ActiveFixtureTest.php Outdated Show resolved Hide resolved
tests/ActiveFixtureTest.php Outdated Show resolved Hide resolved
ziaratban and others added 4 commits October 31, 2020 08:27
ziaratban and others added 4 commits October 31, 2020 08:27
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
@samdark samdark modified the milestones: 2.1.10, 2.1.11 Nov 10, 2020
@samdark samdark modified the milestones: 2.1.11, 2.1.12 Dec 23, 2020
@samdark samdark removed this from the 2.1.12 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants