Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHAN refactoring improvements #4537

Merged
merged 13 commits into from
Nov 14, 2023
Merged

PHAN refactoring improvements #4537

merged 13 commits into from
Nov 14, 2023

Commits on Sep 27, 2023

  1. Remove return type from docblock. 

    Fixes:
- base/CComponent.php:148 PhanTypeMagicVoidWithReturn Found a return statement with a value in the implementation of the magic method \CComponent::__set, expected void return type
- base/CComponent.php:215 PhanTypeMagicVoidWithReturn Found a return statement with a value in the implementation of the magic method \CComponent::__unset, expected void return type
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    3c5da1f View commit details
    Browse the repository at this point in the history

  2. Remove return type from docblock. 

    Fixes:
- base/CSecurityManager.php:528 PhanTypeMissingReturn Method \CSecurityManager::validateEncryptionKey is declared to return bool in phpdoc but has no return value
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    b2cd43b View commit details
    Browse the repository at this point in the history

  3. Remove return type from docblock. 

    Fixes:
- caching/CCache.php:376 PhanTypeMissingReturn Method \CCache::offsetUnset is declared to return bool in phpdoc but has no return value
- caching/CDummyCache.php:164 PhanTypeMissingReturn Method \CDummyCache::offsetUnset is declared to return bool in phpdoc but has no return value
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    0259dd5 View commit details
    Browse the repository at this point in the history

  4. Remove return type from docblock. 

    Fixes:
- cli/commands/shell/ModelCommand.php:127 PhanTypeMissingReturn Method \ModelCommand::generateRelations is declared to return array in phpdoc but has no return value
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    bd71ed3 View commit details
    Browse the repository at this point in the history

  5. Set argument name in docblock. 

    Fixes:
- db/schema/mssql/CMssqlPdoAdapter.php:23 PhanUnextractableAnnotationElementName Saw possibly unextractable annotation for a fragment of comment '* @param string|null sequence name. Defaults to null': after string|null, did not see an element name (will guess based on comment order)
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    a163dad View commit details
    Browse the repository at this point in the history

  6. Add missing argument names to docblocks. 

    Fixes:
- gii/generators/model/ModelCode.php:365 PhanUnextractableAnnotationElementName Saw possibly unextractable annotation for a fragment of comment '* @param CDbTableSchema table to inspect': after CDbTableSchema, did not see an element name (will guess based on comment order)
- gii/generators/model/ModelCode.php:397 PhanUnextractableAnnotationElementName Saw possibly unextractable annotation for a fragment of comment '* @param string the name of the table to hold the relation': after string, did not see an element name (will guess based on comment order)
- gii/generators/model/ModelCode.php:398 PhanUnextractableAnnotationElementName Saw possibly unextractable annotation for a fragment of comment '* @param string the foreign key name': after string, did not see an element name (will guess based on comment order)
- gii/generators/model/ModelCode.php:399 PhanUnextractableAnnotationElementName Saw possibly unextractable annotation for a fragment of comment '* @param boolean whether the relation would contain multiple objects': after boolean, did not see an element name (will guess based on comment order)
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    9a4506c View commit details
    Browse the repository at this point in the history

  7. Remove return type from docblock. 

    Fixes:
- gii/generators/model/ModelGenerator.php:12 PhanTypeMissingReturn Method \ModelGenerator::actionGetTableNames is declared to return string in phpdoc but has no return value
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    f6ec8de View commit details
    Browse the repository at this point in the history

  8. Remove ignored overwritten array key 

    Fixes:
- messages/ca/yii.php:88 PhanPluginDuplicateArrayKey Duplicate/Equivalent array key value('Alias "{alias}" is invalid. Make sure it points to an existing directory or file.') detected in array - the earlier entry 'Alias "{alias}" is invalid. Make sure it points to an existing directory or file.' at line 87 will be ignored.
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    7784c94 View commit details
    Browse the repository at this point in the history

  9. Remove argument from docblock 

    Fixes:
- web/CHttpSessionIterator.php:33 PhanUnextractableAnnotationElementName Saw possibly unextractable annotation for a fragment of comment '* @param array the data to be iterated through': after array, did not see an element name (will guess based on comment order)
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    679f11b View commit details
    Browse the repository at this point in the history

  10. Remove return type from docblock. 

    Fixes:
- web/actions/CViewAction.php:98 PhanTypeMissingReturn Method \CViewAction::resolveView is declared to return string in phpdoc but has no return value
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    3ca2acc View commit details
    Browse the repository at this point in the history

  11. Remove return type from docblock. 

    Fixes:
- web/widgets/COutputCache.php:162 PhanTypeMissingReturn Method \COutputCache::filter is declared to return bool in phpdoc but has no return value
    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    71be1d2 View commit details
    Browse the repository at this point in the history

  12. Update CHANGELOG

    @marcovtwout
    marcovtwout committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    dd77c67 View commit details
    Browse the repository at this point in the history

  13. Update CHANGELOG 

    Typo
    @marcovtwout
    marcovtwout authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    ab7b70f View commit details
    Browse the repository at this point in the history