Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7: Validate that DataReader is not both sortable and limited for GridView #215

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix #7: Validate that DataReader is not both sortable and limited for GridView #215

wants to merge 6 commits into from

Conversation

samdark
Copy link
Member

@samdark samdark commented Sep 13, 2024

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

@samdark samdark requested a review from vjik September 13, 2024 19:45
vjik
vjik requested changes Sep 14, 2024
View reviewed changes
src/GridView.php Outdated Show resolved Hide resolved
@samdark samdark requested a review from vjik September 22, 2024 18:44
@samdark samdark added the status:code review The pull request needs review. label Sep 25, 2024
vjik
vjik requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not enough. Sort don't availaible in header, but use sort parameters from URL.

vjik
vjik requested changes Sep 29, 2024
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another problem is founded: when limit is pre-defined links in paginator contains sort parameter.

@samdark
Copy link
Member Author

samdark commented Sep 29, 2024

@vjik yiisoft/data#201

@samdark samdark requested a review from vjik September 29, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossaddison rossaddison rossaddison left review comments

@vjik vjik Awaiting requested review from vjik

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samdark @vjik @rossaddison @StyleCIBot