Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OffsetPagination.php #178

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Update OffsetPagination.php #178

merged 3 commits into from
Mar 31, 2024

Conversation

aphraoh
Copy link
Contributor

@aphraoh aphraoh commented Mar 30, 2024

In OffsetPagination, no way of setting private member variables $labelPrevious, $labelNext, $labelFirst, $labelLast (Issue #177)

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️

In OffsetPagination, no way of setting private member variables $labelPrevious, $labelNext, $labelFirst, $labelLast (Issue yiisoft#177)
Copy link

what-the-diff bot commented Mar 30, 2024

PR Summary

  • Enhanced Navigation Functions
    We have enhanced our application's navigation abilities by adding four new methods to the OffsetPagination class. These methods help in browsing easily through available data to the previous set, next set, first set, and last set. This greatly improves user experience by enabling quick data navigation.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 64.92%. Comparing base (7b94884) to head (d732582).

❗ Current head d732582 differs from pull request most recent head 39a6de4. Consider uploading reports for the commit 39a6de4 to get more accurate results

Files Patch % Lines
src/OffsetPagination.php 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
- Coverage     65.49%   64.92%   -0.58%     
- Complexity      543      547       +4     
============================================
  Files            46       46              
  Lines          1820     1836      +16     
============================================
  Hits           1192     1192              
- Misses          628      644      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 70933b9 into yiisoft:master Mar 31, 2024
14 of 15 checks passed
@vjik
Copy link
Member

vjik commented Mar 31, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants