Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use any ReadableDataInterface instance #131

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Allow use any ReadableDataInterface instance #131

merged 4 commits into from
Nov 21, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 16, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues -

Depends on yiisoft/data#150

Copy link

what-the-diff bot commented Nov 16, 2023

PR Summary

  • Introduction of New Interfaces and Exceptions
    New interfaces such as Yiisoft\Data\Reader\ReadableDataInterface and new exceptional handling measures like Yiisoft\Yii\DataView\Exception\DataReaderNotSetException are integrated into BaseListView.php. Additionally, a new Exception file DataReaderNotSetException.php was added.

  • Method Shifts in BaseListView.php
    Key functional methods like getDataReader and paginator() are replaced for direct usage of dataReader property and creation of dataReader() method respectively. A method getItems was also devised to fetch items directly from the dataReader.

  • Changes in GridView.php and ListView.php
    Revisions in method parameters were carried out in these files with changes in renderItems() methods. The getDataReader methods were removed and their functionalities replaced with dataReader properties.

  • Updates in Test Files
    A plethora of test files, namely CheckboxColumnTest.php, ActionColumnTest.php, GridViewTest.php, and ListViewTest.php reflects similar changes as in BaseListView.php. paginator() and getdataReader methods were superseded with the dataReader() method and dataReader properties respectively.

  • Further Test File Revisions
    More files have adjusted their paginator() method calls to dataReader(). The file list consists of DataColumnFilterTest.php, DataColumnTest.php, RadioColumnTest.php, BaseTest.php, ExceptionTest.php, ImmutableTest.php, and TranslatorTest.php. Diverse files such as ExceptionTest.php in the ListView directory have converted from the PaginatorNotSetException to DataReaderNotSetException.

  • Pagination Test File Revisions
    Test files regarding Pagination (KeysetPaginationBaseTest.php and OffsetPaginationBaseTest.php) have also shifted from paginator calls to dataReader calls for method invocation.

@vjik vjik changed the title Allow use any instance ReadableDataInterface Allow use any ReadableDataInterface instance Nov 16, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (13e8e93) 100.00% compared to head (6476233) 99.87%.

Files Patch % Lines
src/BaseListView.php 95.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              master     #131      +/-   ##
=============================================
- Coverage     100.00%   99.87%   -0.13%     
- Complexity       470      474       +4     
=============================================
  Files             19       20       +1     
  Lines           1559     1559              
=============================================
- Hits            1559     1557       -2     
- Misses             0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik marked this pull request as ready for review November 21, 2023 08:12
@vjik vjik added the status:code review The pull request needs review. label Nov 21, 2023
@vjik vjik requested a review from a team November 21, 2023 08:12
@vjik vjik merged commit 912e2d9 into master Nov 21, 2023
21 of 23 checks passed
@vjik vjik deleted the concept branch November 21, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants