Add types to ViewInterface::setParameter() and `ViewInterface::addT…

…oParameter()` parameters
yiisoft · May 27, 2024 · b494b63 · b494b63
1 parent e454355
commit b494b63
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@
 - New #242: Add `View::getLocale()` and `WebView::getLocale()` methods (@Tigrov)
 - Enh #250: Make event dispatcher in `View` and `WebView` optional (@vjik)
 - Enh #251: Make base path in `View` and `WebView` optional (@vjik)
+- Enh #248: Add types to `ViewInterface::setParameter()` and `ViewInterface::addToParameter()` parameters (@vjik)
 
 ## 8.0.0 February 16, 2023
 

diff --git a/composer.json b/composer.json
@@ -39,7 +39,7 @@
     "require-dev": {
         "maglnet/composer-require-checker": "^4.2",
         "phpunit/phpunit": "^9.5",
-        "rector/rector": "^1.0",
+        "rector/rector": "1.0.*",
         "roave/infection-static-analysis-plugin": "^1.25",
         "spatie/phpunit-watcher": "^1.23",
         "vimeo/psalm": "^4.30|^5.20",

diff --git a/rector.php b/rector.php
@@ -23,7 +23,6 @@
     ]);
 
     $rectorConfig->skip([
-        MixedTypeRector::class,
         RemoveExtraParametersRector::class => [__DIR__ . '/src/PhpTemplateRenderer.php'],
     ]);
 };
diff --git a/src/ViewInterface.php b/src/ViewInterface.php
@@ -156,7 +156,7 @@ public function setParameters(array $parameters): static;
      * @param string $id The unique identifier of the parameter.
      * @param mixed $value The value of the parameter.
      */
-    public function setParameter(string $id, $value): static;
+    public function setParameter(string $id, mixed $value): static;
 
     /**
      * Add values to end of common array parameter. If specified parameter does not exist or him is not array,
@@ -167,7 +167,7 @@ public function setParameter(string $id, $value): static;
      *
      * @throws InvalidArgumentException When specified parameter already exists and is not an array.
      */
-    public function addToParameter(string $id, ...$value): static;
+    public function addToParameter(string $id, mixed ...$value): static;
 
     /**
      * Removes a common parameter.