Fix test of timeout PDOException: Packets out of order
#352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=========================================
Coverage 98.70% 98.70%
- Complexity 172 173 +1
=========================================
Files 15 15
Lines 539 540 +1
=========================================
+ Hits 532 533 +1
Misses 7 7 ☔ View full report in Codecov by Sentry. |
samdark
reviewed
Aug 29, 2024
|
|
||
| $this->assertSame('1', $result); | ||
|
|
||
| $db->close(); | ||
| } | ||
|
|
||
| public function testNotRestartConnectionOnTimeoutInTransaction(): void |
There was a problem hiding this comment.
I thought we were going to restart it without error.
There was a problem hiding this comment.
If a query in a transaction it is not correct to retry the query in the new connection out of the transaction.
We can close the old connection but the error will still be thrown.
samdark
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR