Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DDLQueryBuilder::getColumnDefinition() #320

Merged
merged 9 commits into from
Apr 13, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Feb 3, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC? ✔️/❌
Fixed issues -

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (df7cf71) to head (3812453).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #320      +/-   ##
============================================
+ Coverage     99.08%   99.26%   +0.17%     
+ Complexity      183      181       -2     
============================================
  Files            15       15              
  Lines           549      547       -2     
============================================
- Hits            544      543       -1     
+ Misses            5        4       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Feb 3, 2024

PR Summary

  • New Feature in DDLQueryBuilder
    A new capability has been added to the DDLQueryBuilder for more functionality.

  • Changes in Accessibility of getColumnDefinition Method
    The accessibility of a particular function in DDLQueryBuilder, getColumnDefinition(), has been altered from being open to all, to being confined to its class only.

  • Additional Testing for DDLQueryBuilder's renameColumn Method
    More comprehensive testing has been implemented in the QueryBuilderTest class for the renameColumn() operation of DDLQueryBuilder. This covers scenarios like renaming an established column and trying to rename a column that doesn't exist within existing and non-existent tables.

@Tigrov Tigrov mentioned this pull request Feb 3, 2024
@Tigrov Tigrov added the status:code review The pull request needs review. label Feb 3, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
src/DDLQueryBuilder.php Show resolved Hide resolved
@vjik vjik merged commit a181ab6 into master Apr 13, 2024
78 of 80 checks passed
@vjik vjik deleted the refactor-getColumnDefinition branch April 13, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants