Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnSchema classes for performance of typecasting #303

Merged
merged 12 commits into from
May 30, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 1, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues yiisoft/db#737

@what-the-diff
Copy link

what-the-diff bot commented Sep 1, 2023

PR Summary

  • Deprecated Notice in ColumnSchema class
    Modifications to the ColumnSchema class now indicate that it's deprecated or phased out. The methods phpTypecast and dbTypecast in this class will continue to work for now but may be removed in future updates.

  • Improved Testing in ColumnSchemaTest class
    Various changes have been made to the ColumnSchemaTest test class, making testing more robust. New types of columns are now tested, and the JsonColumnSchema class replaces the deprecated ColumnSchema class in certain tests. Plus, a new method tests whether the right column schema class is used for each column type.

  • Added BigUnsigned Column in SchemaProvider class
    The SchemaProvider class now has a new column bigunsigned_col. This column can hold very large, positive whole number values, defaulting to 12345678901234567890.

  • Changes in SchemaTest Test Class
    In the SchemaTest test class, new expectations for int_col have been established where it now expects the StringColumnSchema class instead of the older ColumnSchema.

  • Addition in mysql.sql fixture file
    The mysql.sql fixture file now includes a new bigunsigned_col column in the type table. This column can hold large, unsigned integers, and it defaults to 12345678901234567890.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.25%. Comparing base (02685f0) to head (dbeea65).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
- Coverage     99.26%   99.25%   -0.02%     
+ Complexity      181      168      -13     
============================================
  Files            15       14       -1     
  Lines           547      534      -13     
============================================
- Hits            543      530      -13     
  Misses            4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review September 1, 2023 15:37
@Tigrov Tigrov added the status:under development Someone is working on a pull request. label Jan 31, 2024
@Tigrov Tigrov added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels May 5, 2024
@Tigrov Tigrov merged commit b177c8b into yiisoft:master May 30, 2024
75 of 80 checks passed
@Tigrov Tigrov deleted the column_type_classes2 branch May 30, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants