Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ETH starter vault #7

Open
wants to merge 2 commits into
base: eth-starter-vault
Choose a base branch
from
Open

Feature: ETH starter vault #7

wants to merge 2 commits into from

Conversation

xhad
Copy link
Collaborator

@xhad xhad commented Oct 18, 2024

This converts the SingleVault to and WETH 4626 vault.

Notes:

  1. Adds a fallback function to convert eth to WETH and deposit for shares from direct transfers
  2. Remove all of the timelock controller for function admin
  3. Updated tests, but still need to do a few more

@xhad xhad changed the title Convert to ETH starter vault Feature: Convert to ETH starter vault Oct 18, 2024
@xhad xhad added the WIP label Oct 18, 2024
@xhad xhad changed the title Feature: Convert to ETH starter vault Feature: ETH starter vault Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danoctavian danoctavian Awaiting requested review from danoctavian

@gearcat0 gearcat0 Awaiting requested review from gearcat0

@johnnyonline johnnyonline Awaiting requested review from johnnyonline

Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xhad