Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rewards distributor public on nodes manager #46

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Make rewards distributor public on nodes manager #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be4aa3f
Makes rewardsDistributor state variable public
xhad Mar 19, 2024
f4a7776
Fix stETH balance assertion with compareWithThreshold
xhad Mar 19, 2024
ff2f468
Fix: Use ether value
xhad Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/StakingNodesManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ contract StakingNodesManager is
UpgradeableBeacon public upgradeableBeacon;

IynETH public ynETH;
IRewardsDistributor rewardsDistributor;
IRewardsDistributor public rewardsDistributor;

Validator[] public validators;

Expand Down
4 changes: 2 additions & 2 deletions test/foundry/integration/ynLSD.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ contract ynLSDAdminTest is IntegrationBaseTest {

function testRetrieveAssetsSuccess() public {
IERC20 asset = IERC20(chainAddresses.lsd.STETH_ADDRESS);
uint256 amount = 64;
uint256 amount = 64 ether;

vm.prank(actors.STAKING_NODE_CREATOR);
ynlsd.createLSDStakingNode();
Expand All @@ -358,7 +358,7 @@ contract ynLSDAdminTest is IntegrationBaseTest {
(bool success, ) = chainAddresses.lsd.STETH_ADDRESS.call{value: amount + 1}("");
require(success, "ETH transfer failed");
uint256 balance = asset.balanceOf(address(this));
assertEq(balance, amount, "Amount not received");
assertEq(compareWithThreshold(balance, amount, 1), true, "Amount not received");

asset.approve(address(ynlsd), amount);
ynlsd.deposit(asset, amount, address(this));
Expand Down
Loading