fix wrong address #169
Merged
fix wrong address #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danoctavian
commented
Sep 18, 2024
| @@ -23,7 +23,7 @@ | |||
| "proxy-eigenStrategyManager": "0x92D904019A92B0Cafce3492Abb95577C285A68fC", | |||
| "proxy-rateProvider": "0xb658Cf6F4C232Be5c6035f2b42b96393089F20D9", | |||
| "proxy-tokenStakingNodesManager": "0x6B566CB6cDdf7d140C59F84594756a151030a0C3", | |||
| "proxy-ynEigenDepositAdapter": "0xA9CD5a5199177b704287e379e85af95F0f061Bf2", | |||
| "proxy-ynEigenDepositAdapter": "0x9e72155d301a6555dc565315be72D295c76753c0", | |||
There was a problem hiding this comment.
this was set to the implementation by accident
danoctavian
commented
Sep 18, 2024
deployments/YnLSDe-17000.json
Outdated
| @@ -25,10 +25,10 @@ | |||
| "proxy-tokenStakingNodesManager": "0x5c20D1a85C7d9acB503135a498E26Eb55d806552", | |||
| "proxy-ynEigenDepositAdapter": "0x7d0c1F604571a1c015684e6c15f2DdEc432C5e74", | |||
| "proxy-ynEigenViewer": "0xECCE549926637E974Ca5739a8827E612682415E7", | |||
| "proxyAdmin-YnLSDe": "0x92Df7b6001EF4cFe40B6b425bC4a358c05f27624", | |||
| "proxyAdmin-YnLSDe": "0x31456Eef519b7ab236e3638297Ed392390bf304F", | |||
There was a problem hiding this comment.
this was set to the implementation of ynLSDe
danoctavian
commented
Sep 18, 2024
| "proxyAdmin-assetRegistry": "0x4248392db8Ee31aA579822207d059A28A38c4510", | ||
| "proxyAdmin-eigenStrategyManager": "0x010c60d663fddDAA076F0cE63f6692f0b5605fE5", | ||
| "proxyAdmin-rateProvider": "0x401af3714dc0c0d28f752dbdd70cf423c667246e", | ||
| "proxyAdmin-rateProvider": "0xD7E36d7f08ea756bb699B679B49F3095Cb6F7AB8", |
There was a problem hiding this comment.
this was set to a previous implementation of rateProvider
danoctavian
commented
Sep 18, 2024
| "implementation-assetRegistry": "0x7385f1dBF3b0Ee3d85c89A38901Aa87333D30946", | ||
| "implementation-eigenStrategyManager": "0xc599064e66FB509FD49B5083896649a742066758", | ||
| "implementation-rateProvider": "0x94009d1296dc2e6370Aa34c94BEDFeD55f96a276", | ||
| "implementation-rateProvider": "0x0Ca50907B8B5fDc6b0B1d5F23195209aD0457113", |
There was a problem hiding this comment.
latest implementation
danoctavian
commented
Sep 18, 2024
| @@ -11,24 +11,24 @@ | |||
| "UNPAUSE_ADMIN": "0x743b91CDB1C694D4F51bCDA3a4A59DcC0d02b913", | |||
| "YNDev": "0x9Dd8F69b62ddFd990241530F47dcEd0Dad7f7d39", | |||
| "YnSecurityCouncil": "0x743b91CDB1C694D4F51bCDA3a4A59DcC0d02b913", | |||
| "implementation-YnLSDe": "0xA6cf070663127FAa41a2150BdadAD8D84b876AEb", | |||
| "implementation-ynLSDe": "0x92Df7b6001EF4cFe40B6b425bC4a358c05f27624", | |||
There was a problem hiding this comment.
latest implementation
danoctavian
commented
Sep 18, 2024
| "proxy-assetRegistry": "0xaD31546AdbfE1EcD7137310508f112039a35b6F7", | ||
| "proxy-eigenStrategyManager": "0xA0a11A9b84bf87c0323bc183715a22eC7881B7FC", | ||
| "proxy-rateProvider": "0xd68C29263F6dC2Ff8D9307b3AfAcD6D6fDeFbB3A", | ||
| "proxy-tokenStakingNodesManager": "0x5c20D1a85C7d9acB503135a498E26Eb55d806552", | ||
| "proxy-ynEigenDepositAdapter": "0x7d0c1F604571a1c015684e6c15f2DdEc432C5e74", | ||
| "proxy-ynEigenViewer": "0xECCE549926637E974Ca5739a8827E612682415E7", | ||
| "proxyAdmin-YnLSDe": "0x92Df7b6001EF4cFe40B6b425bC4a358c05f27624", | ||
| "proxyAdmin-ynLSDe": "0x31456Eef519b7ab236e3638297Ed392390bf304F", |
There was a problem hiding this comment.
this was set to the implementation, not the proxy erroneously
danoctavian
commented
Sep 18, 2024
| "name": "RETH", | ||
| "token": "0xae78736Cd615f374D3085123A210448E74Fc6393", | ||
| "strategy": "0x1BeE69b7dFFfA4E2d53C2a2Df135C388AD25dCD2" | ||
| "name": "METH", |
There was a problem hiding this comment.
after update by RaidGuild this descriptor file checked for RETH instead of METH - updated.
gearcat0
approved these changes
Sep 18, 2024
xhad
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon a previous upgrade erroneous changes were made to the deployment files and new implementations updated the wrong file fields.
Also json field names are updated to work with the verifier scripts as shown below:
To check deployment integrity run:
make ynEigen-verify path=script/ynEigen/input/lsd-holesky.json rpc="https://rpc.ankr.com/eth_holesky" deployer=0x72fdbd51085bda5eeed3b55d1a46e2e92f0837a5 api=[etherscan-apikey]make ynEigen-verify path=script/ynEigen/input/lsd-mainnet.json rpc="[mainnet-rpc]" deployer=0x72fdbd51085bda5eeed3b55d1a46e2e92f0837a5 api=[etherscan-apikey]