Make geom_hline and geom_vline consistent with documentation and with R's ggplot2 #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #597 and #545, both to match the docs, and to make it more consistent with ggplot2 (it uses 'yintercept' and 'xintercept', which is why some docs do too), while maintaining backward compatibility with those who have used the 'x' or 'y' param, since that's all you could do to get it working previously.
Also toss a ValueError if neither x/y nor xintercept/yintercept are set when plotting (instead of ambiguous and unhelpful type comparison exception).
Looks like that makes this doc incorrect, though. Will fix that one next.