Added dialog buttons for all dialogs (#44) #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrgGrch
reviewed
Aug 10, 2023
| @@ -127,7 +127,7 @@ class DnsActivity : AppCompatActivity() { | |||
| view.findViewById<ImageButton>(R.id.deletePeerButton).tag = i | |||
|
|
|||
| view.findViewById<ImageButton>(R.id.deletePeerButton).setOnClickListener { button -> | |||
| val builder: AlertDialog.Builder = AlertDialog.Builder(this) | |||
| val builder: AlertDialog.Builder = AlertDialog.Builder(ContextThemeWrapper(this, R.style.Theme_MaterialComponents_DayNight_Dialog)) | |||
There was a problem hiding this comment.
I don't think that this solution is optimal. The core problem is that colorPrimary in themes.xml is set to white. Buttons are already exist, but their text color is white.
I think the best solution is to change primary color in theme.
Signed-off-by: Revertron <[email protected]>
|
@neilalexander Can you approve this? LGTM. |
|
Superseded by #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no buttons in the dialog boxes, I fixed that. Causes #44