Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add operators data periodic fetcher #1152

Merged
merged 2 commits into from
Oct 3, 2024
Merged

feat: Add operators data periodic fetcher #1152

merged 2 commits into from
Oct 3, 2024

Conversation

JulianVentura
Copy link
Collaborator

@JulianVentura JulianVentura commented Oct 2, 2024 •
edited
Loading

Description

This PR adds a periodic data fetch of operands data making use of a Task.

How to test

  1. Run telemetry service without any operator registered
  2. Go to localhost:4000 and data should be empty
  3. Register an operator
  4. Go to localhost:4000 and data from operator should have appeared
  5. Run the registered operator
  6. Go to localhost:4000 and the operator's version should appear.

Closes #1137

@JulianVentura JulianVentura changed the base branch from testnet to 1075-feattelemetry-implement-telemetry-for-aggregator October 2, 2024 19:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Changes to gas cost

Generated at commit: 55668574db90a3da8fa7925b8911881887b6963c, compared to commit: 0f535bef99c157e450dba7006d25330afb6f35e7

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask +22 ❌ +0.03%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 4,681,797 (+52,382) createNewTask 53,967 (+144) +0.27% 73,911 (+22) +0.03% 73,987 (0) 0.00% 74,734 (0) 0.00% 256 (0)
RegistryCoordinatorHarness 5,846,016 (+17,263)

@JulianVentura JulianVentura marked this pull request as ready for review October 2, 2024 19:44
avilagaston9
avilagaston9 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avilagaston9 avilagaston9 mentioned this pull request Oct 3, 2024
Merged
9 tasks
@JuArce JuArce linked an issue Oct 3, 2024 that may be closed by this pull request
feat(telemetry): track operators events #1137
Open
@avilagaston9 avilagaston9 merged commit abd3690 into 1075-feattelemetry-implement-telemetry-for-aggregator Oct 3, 2024
@avilagaston9 avilagaston9 deleted the feat/telemetry-operator-fetcher branch October 3, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oppen Oppen Oppen left review comments

@avilagaston9 avilagaston9 avilagaston9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(telemetry): track operators events
3 participants
@JulianVentura @Oppen @avilagaston9