Implement a repeat_until_end format.
#361
Conversation
| Because the repeat format does not have a predefined length, it is | ||
| [represented](#format-representations) as a dynamically sized | ||
| [array type](#array-types): |
There was a problem hiding this comment.
Is it possible to access the length once parsed? Do we need to mention that the repeat format doesn't need to be of fixed size?
There was a problem hiding this comment.
Yeah, I think I'll need to get up to adding sizing to this reference, like how I talk about the host representation types.
Are you thinking the byte length? Or the number of elements in the array?
There was a problem hiding this comment.
I was thinking of number of elements in the array, as the byte length could be determined by following it with a pos.
| Err(err) => match err.kind() { | ||
| io::ErrorKind::UnexpectedEof => { | ||
| // FIXME: should this be set to the end of the current stream? | ||
| reader.seek(SeekFrom::Start(current_pos))?; | ||
| return Ok(Arc::new(Value::ArrayLit(elems))); | ||
| } | ||
| _ => return Err(err), |
There was a problem hiding this comment.
Does this allow trailing random bytes at the end of the stream?
There was a problem hiding this comment.
Ahh yeah it does - I was thinking of maybe adding a repeat_until_end_exact format.
|
Sorry for being hasty in merging this @mikeday! 😳 |
|
No problems with the merge, just curious! |
This implements a
repeat_until_endformat, along with anArraytype with no length. We could add more repeat formats later in order to address the needs of #352.These commits were taken from #310.