Codegen fixes #135
Open
Codegen fixes #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archaephyrryx
force-pushed
the
codegen-fixes
branch
from
c56eeeb
to
7862927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
ParseCtxt, simple abstraction for threading an incrementally-consumedReadCtxtthrough Decoders without forcing them to change return-value. This does not allow for backtracking or splitting, at least as implemented currently.Fixes broken label sanitization rules, and suppresses them entirely for the contents of string literals.
Adds a manual test at the end of
sample_codegen.rsto confirm that parsing can actually work.